Skip to content

Port SequencerEntrypoint to use ovm solc#535

Merged
smartcontracts merged 9 commits intomasterfrom
ovm-solc/sequencer-entrypoint
Apr 21, 2021
Merged

Port SequencerEntrypoint to use ovm solc#535
smartcontracts merged 9 commits intomasterfrom
ovm-solc/sequencer-entrypoint

Conversation

@smartcontracts
Copy link
Copy Markdown
Contributor

@smartcontracts smartcontracts commented Apr 21, 2021

Description
Breaking #475 into several PRs for simplicity. First PR here is porting OVM_SequencerEntrypoint to use the l2 compiler.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 21, 2021

🦋 Changeset detected

Latest commit: 2f2459e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@eth-optimism/contracts Patch
@eth-optimism/hardhat-ovm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Collaborator

@ben-chain ben-chain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Only change we need to make is fix the TEMP compiler version. I'm gonna build a version based off of master now that we can use; hopefully @smartcontracts has a good way to invalidate the cache to make sure it updates.

Copy link
Copy Markdown
Collaborator

@ben-chain ben-chain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the temp removed, LGTM! ( I reviewed this more extensively in #475 and feedback was addressed :) )

Copy link
Copy Markdown
Contributor

@karlfloersch karlfloersch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I noticed there might be a dependency that I think we can remove but overall this looks great!

Going to comb over the tests in a little more detail and follow up with more review

Copy link
Copy Markdown
Contributor

@karlfloersch karlfloersch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah @smartcontracts don't forget to add a changeset

Copy link
Copy Markdown
Contributor

@karlfloersch karlfloersch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dope!

@smartcontracts smartcontracts merged commit c75a0fc into master Apr 21, 2021
@smartcontracts smartcontracts deleted the ovm-solc/sequencer-entrypoint branch April 21, 2021 19:52
InoMurko referenced this pull request in omgnetwork/optimism May 25, 2021
* port SequencerEntrypoint to use ovm solc

* Minor tweaks and comments

* have hardhat-ovm invalidate cache on commit to solc-bin

* remove temporary solc version override

* have cache invalidation on a per-version basis

* remove ethereumjs-util dep

* fix lint error

* use allow_kall_2 compiler until build is fixed

* add changeset
theochap pushed a commit that referenced this pull request Dec 10, 2025
* chore(preimage): Improve error differentiation in preimage servers

* test unblock on failure for hintrouter

* assert err

* fix bad utf8 unblocking
theochap pushed a commit that referenced this pull request Jan 15, 2026
Renames `InvalidInboxEntry` to `SuperchainDAError`.

Some of these error variants occur also on updating superchain state.
The name `InvalidInboxEntry` is to specialised for
`supervisor_checkAccessList`.

Adds feature `jsonrpsee` to `op-alloy-rpc-types` and feature gated
conversion to `jsonrpsee::ErrorObjectOwned`.
emhane added a commit that referenced this pull request Feb 4, 2026
…_block_updates` (#535)

Closes #523

---------

Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants